Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set global variable tidb_txn_mode to pessimistic during bootstrap. #14154

Merged
merged 3 commits into from
Dec 20, 2019
Merged

set global variable tidb_txn_mode to pessimistic during bootstrap. #14154

merged 3 commits into from
Dec 20, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented Dec 20, 2019

What problem does this PR solve?

Make the default tidb_txn_mode to pessimistic but do not affects the existing clusters.

What is changed and how it works?

Set the global variable tidb_txn_mode to pessimistic during bootstrap.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. start an old version cluster, upgrade the cluster to this version, verify that @@global.tidb_txn_mode is still empty string.
  2. clear data and start a new cluster of this version, verify that @@global.tidb_txn_mode is pessimistic.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • set the initial global variable value of tidb_txn_mode to pessimistic during bootstrap.

@coocood coocood added the sig/transaction SIG:Transaction label Dec 20, 2019
@coocood
Copy link
Member Author

coocood commented Dec 20, 2019

/run-all-tests

@coocood
Copy link
Member Author

coocood commented Dec 20, 2019

/run-unit-test

jackysp
jackysp reviewed Dec 20, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member Author

coocood commented Dec 20, 2019

/run-all-tests

@coocood
Copy link
Member Author

coocood commented Dec 20, 2019

/run-integration-copr-test

lysu
lysu approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT3 The PR has already had 3 LGTM. label Dec 20, 2019
@jackysp
Copy link
Member

jackysp commented Dec 20, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot sre-bot merged commit c7c7b73 into pingcap:master Dec 20, 2019
@sre-bot sre-bot mentioned this pull request Dec 20, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

cherry pick to release-3.0 in PR #14171

sre-bot added a commit that referenced this pull request Dec 21, 2019
@sre-bot
set global variable tidb_txn_mode to pessimistic during bootstrap. (#…
adbb8b9 
…14154) (#14171)
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@coocood @XiaTianliang
set global variable tidb_txn_mode to pessimistic during bootstrap. (p…
93d71e7 
…ingcap#14154)
@coocood coocood deleted the bootstrap-pessimistic branch December 23, 2019 01:59
@you06 you06 mentioned this pull request Nov 15, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coocood @tiancaiamao @jackysp @sre-bot @lysu