Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set global variable tidb_txn_mode to pessimistic during bootstrap. (#14154) #14171

Merged
merged 1 commit into from
Dec 21, 2019
Merged

set global variable tidb_txn_mode to pessimistic during bootstrap. (#14154) #14171

merged 1 commit into from
Dec 21, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 20, 2019

cherry-pick #14154 to release-3.0

What problem does this PR solve?

Make the default tidb_txn_mode to pessimistic but do not affects the existing clusters.

What is changed and how it works?

Set the global variable tidb_txn_mode to pessimistic during bootstrap.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. start an old version cluster, upgrade the cluster to this version, verify that @@global.tidb_txn_mode is still empty string.
  2. clear data and start a new cluster of this version, verify that @@global.tidb_txn_mode is pessimistic.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • set the initial global variable value of tidb_txn_mode to pessimistic during bootstrap.

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Dec 20, 2019
Merged
lysu
lysu reviewed Dec 21, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2019
lonng
lonng approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2019
@jackysp
Copy link
Member

jackysp commented Dec 21, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit adbb8b9 into pingcap:release-3.0 Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@lonng lonng lonng approved these changes

@jackysp jackysp Awaiting requested review from jackysp

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @jackysp @lysu @lonng @coocood