-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: enable if/bitxor/bitneg pushdown for TiFlash #17626
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17626 +/- ##
===========================================
Coverage 79.5357% 79.5357%
===========================================
Files 520 520
Lines 140386 140386
===========================================
Hits 111657 111657
Misses 19759 19759
Partials 8970 8970 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@windtalker merge failed. |
/run-all-tests |
Signed-off-by: sre-bot <[email protected]>
cherry pick to release-4.0 in PR #17651 |
…7651) Signed-off-by: sre-bot <[email protected]> Co-authored-by: xufei <[email protected]>
What problem does this PR solve?
Problem Summary:
What is changed and how it works?
enable
if/bitxor/bitneg
pushdown for TiFlash, disablenulleq
pushdown for TiFlash because it is not supported yetWhat's Changed:
add
if/bitxor/bitneg
to TiFlash pushdown whitelist, removenulleq
from TiFlash pushdown whitelistRelated changes
Check List
Tests
Release note
if/bitxor/bitneg
pushdown to TiFlashnulleq
pushdown to TiFlash