Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: enable if/bitxor/bitneg pushdown for TiFlash #17626

Merged
merged 5 commits into from
Jun 4, 2020

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Jun 3, 2020

What problem does this PR solve?

Problem Summary:

What is changed and how it works?

enable if/bitxor/bitneg pushdown for TiFlash, disable nulleq pushdown for TiFlash because it is not supported yet

What's Changed:
add if/bitxor/bitneg to TiFlash pushdown whitelist, remove nulleq from TiFlash pushdown whitelist

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

  • Enable if/bitxor/bitneg pushdown to TiFlash
  • Disable nulleq pushdown to TiFlash

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #17626 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17626   +/-   ##
===========================================
  Coverage   79.5357%   79.5357%           
===========================================
  Files           520        520           
  Lines        140386     140386           
===========================================
  Hits         111657     111657           
  Misses        19759      19759           
  Partials       8970       8970           

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2020
@lzmhhh123 lzmhhh123 requested a review from wshwsh12 June 3, 2020 10:37
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

@windtalker merge failed.

@windtalker
Copy link
Contributor Author

/run-all-tests

@lzmhhh123 lzmhhh123 merged commit 2d898ef into pingcap:master Jun 4, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 4, 2020

cherry pick to release-4.0 in PR #17651

@windtalker windtalker deleted the more_expr_support branch June 4, 2020 02:37
sre-bot added a commit that referenced this pull request Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants