Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: enable if/bitxor/bitneg pushdown for TiFlash (#17626) #17651

Merged
merged 3 commits into from
Jun 6, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 4, 2020

cherry-pick #17626 to release-4.0


What problem does this PR solve?

Problem Summary:

What is changed and how it works?

enable if/bitxor/bitneg pushdown for TiFlash, disable nulleq pushdown for TiFlash because it is not supported yet

What's Changed:
add if/bitxor/bitneg to TiFlash pushdown whitelist, remove nulleq from TiFlash pushdown whitelist

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

  • Enable if/bitxor/bitneg pushdown to TiFlash
  • Disable nulleq pushdown to TiFlash

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 4, 2020

/run-all-tests

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 4, 2020
@zz-jason
Copy link
Member

zz-jason commented Jun 4, 2020

/merge

@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 4, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 4, 2020

@sre-bot merge failed.

@windtalker
Copy link
Contributor

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Jun 4, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 4, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 4, 2020

@sre-bot merge failed.

@windtalker
Copy link
Contributor

/run-all-tests

@bb7133 bb7133 modified the milestones: v4.0.1, v4.0.2 Jun 6, 2020
@zz-jason
Copy link
Member

zz-jason commented Jun 6, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 6, 2020

Your auto merge job has been accepted, waiting for:

  • 17694
  • 17680
  • 17681
  • 17648
  • 17705
  • 17719

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit a4bf724 into pingcap:release-4.0 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants