planner: workaround the panic of command EXECUTE when printing an expensive query log #19316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
requested review from
wshwsh12 and
winoros
and removed request for
a team
SunRunAway
force-pushed
the
executepanic2
branch
from
f828dfc
to
508eb41
Compare
ti-srebot
approved these changes
Aug 20, 2020
|
/merge |
|
@SunRunAway Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIGs: planner(slack). |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
|
@SunRunAway merge failed. |
|
/merge |
|
@SunRunAway Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIGs: planner(slack). |
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 20, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #19338 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 20, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.1 in PR #19339 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 20, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #19340 |
winoros
pushed a commit
that referenced
this pull request
Aug 25, 2020
…ensive query log (#19316) (#19339) Co-authored-by: Feng Liyuan <[email protected]>
zz-jason
pushed a commit
that referenced
this pull request
Aug 25, 2020
jebter
pushed a commit
that referenced
this pull request
Aug 25, 2020
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Feng Liyuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: a workaround for #17419
Problem Summary:
session.currentPlanis not set when runs command EXECUTE, so that panic happens if the expensive log is printing.What is changed and how it works?
Because the fix PR #17874 has a test issue that I could not resolve quickly, so this workaround PR is filing.
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
Release note