Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: workaround the panic of command EXECUTE w ... (#19316) #19338

Merged
merged 4 commits into from
Aug 25, 2020
Merged

planner: workaround the panic of command EXECUTE w ... (#19316) #19338

merged 4 commits into from
Aug 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19316 to release-3.0

What problem does this PR solve?

Issue Number: a workaround for #17419

Problem Summary:

session.currentPlan is not set when runs command EXECUTE, so that panic happens if the expensive log is printing.

What is changed and how it works?

Because the fix PR #17874 has a test issue that I could not resolve quickly, so this workaround PR is filing.

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • None

Release note

  • workaround the panic of command EXECUTE when printing an expensive query log

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Aug 20, 2020
Merged
@ti-srebot ti-srebot added sig/planner SIG: Planner type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels Aug 20, 2020
@SunRunAway
Copy link
Contributor

/run-all-tests

@SunRunAway SunRunAway mentioned this pull request Aug 24, 2020
Closed
@SunRunAway
Copy link
Contributor

/run-unit-test

@SunRunAway
Copy link
Contributor

/run-all-tests

lzmhhh123
lzmhhh123 reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2020
winoros
winoros reviewed Aug 25, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2020
@winoros
Copy link
Member

winoros commented Aug 25, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 25, 2020
@zz-jason zz-jason changed the title planner: workaround the panic of command EXECUTE when printing an expensive query log (#19316) planner: workaround the panic of command EXECUTE w ... (#19316) Aug 25, 2020
@zz-jason zz-jason merged commit 76e38a5 into pingcap:release-3.0 Aug 25, 2020
@SunRunAway SunRunAway deleted the release-3.0-57e43bdea3c4 branch August 25, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@zz-jason zz-jason zz-jason approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees

@SunRunAway SunRunAway

Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @SunRunAway @winoros @zz-jason @lzmhhh123