executor: wrong result of nullif expr when used with is null expr. (#23170) #23278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #23170 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23278
After apply modifications, you can push your change to this PR via:
Signed-off-by: guo-shaoge [email protected]
What problem does this PR solve?
Issue Number: close #23157
Problem Summary:
The result of Nullif expr is unexpected, same reason as #23102 .
What is changed and how it works?
Proposal: xxx
What's Changed: In TiDB, we rewrite Nullif(e1, e2) as If(e1 = e2, NULL, e2), so we need to change InferType4ControlFuncs()(which will be call in ifFunctionClass::getFunction), unset NotNullFlag if any argument is NULL.
Related changes
Check List
Tests
Side effects:no
Release note