executor: wrong result of nullif expr when used with is null expr. (#23170)

[ti-srebot]

cherry-pick #23170 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23279

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/23279:release-4.0-f3c64ceecefd

---

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #23157

Problem Summary:

drop table t;
create table t(a int primary key);
insert into t values(1),(2);
select * from t where nullif(a,a) is null;

The result of Nullif expr is unexpected, same reason as #23102 .

What is changed and how it works?

Proposal: xxx

What's Changed: In TiDB, we rewrite Nullif(e1, e2) as If(e1 = e2, NULL, e2), so we need to change InferType4ControlFuncs()(which will be call in ifFunctionClass::getFunction), unset NotNullFlag if any argument is NULL.

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Integration test: TestNullifWithIsNull()

Side effects:no

Release note

• wrong result of nullif expr when used with is null expr

[ti-srebot]

/run-all-tests

[ti-srebot]

@guo-shaoge you're already a collaborator in bot's repo.

[XuHuaiyu]

/lgtm

[ti-chi-bot]

@AilinKid: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[AilinKid]

LGTM

[AilinKid]

/lgtm

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• AilinKid
• XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[zhouqiang-cl]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: f7f00ed

[XuHuaiyu]

/merge

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.