Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "planner: donot prune all columns for Projection (#24024)" #24180

Merged
merged 4 commits into from
Apr 25, 2021
Merged

Revert "planner: donot prune all columns for Projection (#24024)" #24180

merged 4 commits into from
Apr 25, 2021

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Apr 21, 2021 •
edited
Loading

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #24149

Problem Summary: This PR revert this commit . Because it cause case regression. The corresponding issue will be reopend, and will be fixed in next version.

What is changed and how it works?

What's Changed: revert code

Related changes

  • Need to cherry-pick to the release branch: release-5.0 is already reveted.

Check List

Side effects: reopened issues will be fixed later.

Release note

  • No release note

@guo-shaoge guo-shaoge requested a review from a team as a code owner April 21, 2021 03:46
@guo-shaoge guo-shaoge requested review from winoros and removed request for a team April 21, 2021 03:46
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 21, 2021
@guo-shaoge guo-shaoge requested a review from a team as a code owner April 21, 2021 04:53
@guo-shaoge guo-shaoge requested review from lzmhhh123 and removed request for a team April 21, 2021 04:53
@github-actions github-actions bot added the sig/execution SIG execution label Apr 21, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

@XuHuaiyu XuHuaiyu added sig/planner SIG: Planner needs-cherry-pick-release-5.0 type/bugfix This PR fixes a bug. and removed sig/execution SIG execution labels Apr 21, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Apr 21, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

@ichn-hu ichn-hu mentioned this pull request Apr 21, 2021
Closed
@guo-shaoge guo-shaoge changed the title planner: cannot use firstrow unconditionally when prune agg planner: donnot all columns in Projection if its child of Hash/Apply Apr 21, 2021
@guo-shaoge guo-shaoge removed the sig/execution SIG execution label Apr 21, 2021
@guo-shaoge guo-shaoge changed the title planner: donnot all columns in Projection if its child of Hash/Apply Revert "planner: donot prune all columns for Projection (#24024)" Apr 23, 2021
@guo-shaoge
Copy link
Collaborator Author

@lzmhhh123 @winoros PTAL
Also revert in master branch.

@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 23, 2021
eurekaka
eurekaka approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2021
@guo-shaoge
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@guo-shaoge: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@eurekaka
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bcd6dd3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@ti-chi-bot ti-chi-bot merged commit fb676b7 into pingcap:master Apr 25, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 25, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#24180 to release-5.0
3ed911a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24258

@guo-shaoge guo-shaoge mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@eurekaka eurekaka eurekaka approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v5.0.1-pre Inconsistent select count(1)
6 participants
@guo-shaoge @ti-chi-bot @eurekaka @ti-srebot @lzmhhh123 @XuHuaiyu