Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "planner: donot prune all columns for Projection (#24024)" (#24180) #24258

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 25, 2021

cherry-pick #24180 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24258

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/24258:release-5.0-fb676b7697b7

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #24149

Problem Summary: This PR revert this commit . Because it cause case regression. The corresponding issue will be reopend, and will be fixed in next version.

What is changed and how it works?

What's Changed: revert code

Related changes

  • Need to cherry-pick to the release branch: release-5.0 is already reveted.

Check List

Side effects: reopened issues will be fixed later.

Release note

  • No release note

@ti-srebot ti-srebot requested a review from a team as a code owner April 25, 2021 03:48
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot ti-srebot requested review from winoros and removed request for a team April 25, 2021 03:48
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 25, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 25, 2021
@ti-srebot
Copy link
Contributor Author

@guo-shaoge you're already a collaborator in bot's repo.

@guo-shaoge guo-shaoge closed this May 10, 2021
@guo-shaoge
Copy link
Collaborator

This is a cherry pick make by bot. #24202 already finished this cherry pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants