Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add some test cases about partition-table dynamic mode with view #24448

Merged
merged 6 commits into from
May 10, 2021
Merged

executor: add some test cases about partition-table dynamic mode with view #24448

merged 6 commits into from
May 10, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 7, 2021

What problem does this PR solve?

Issue Number: related to #24150

Problem Summary: executor: add some test cases about partition-table dynamic mode with view

What is changed and how it works?

No logical change, just add some test cases about partition-table dynamic mode with view

Check List

Tests

  • Unit test

Release note

  • executor: add some test cases about partition-table dynamic mode with view

@qw4990 qw4990 requested a review from a team as a code owner May 7, 2021 03:36
@qw4990 qw4990 requested review from lzmhhh123 and removed request for a team May 7, 2021 03:36
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2021
@qw4990 qw4990 requested a review from wshwsh12 May 7, 2021 03:36
@qw4990 qw4990 added the sig/planner SIG: Planner label May 7, 2021
@qw4990 qw4990 requested review from rebelice and time-and-fate and removed request for lzmhhh123 and wshwsh12 May 7, 2021 03:36
@qw4990
Copy link
Contributor Author

qw4990 commented May 7, 2021

PTAL @rebelice @time-and-fate

@github-actions github-actions bot added the sig/execution SIG execution label May 7, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2021
rebelice
rebelice approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@rebelice rebelice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
@wshwsh12
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented May 10, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5bd3c71

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented May 10, 2021

/merge

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented May 10, 2021

/merge

@qw4990 qw4990 merged commit 0581cb4 into pingcap:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @wshwsh12 @ti-chi-bot @rebelice