-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, executor: supports select statement with AS OF #24613
Merged
Merged
Changes from 9 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
f9b49db
planner, exector: supports select statement with AS OF
nolouch 2ff63cf
update proto
nolouch 6afe3b9
fix
nolouch 25f55ec
format
nolouch 5fad63c
add more tests
nolouch c0a561a
Merge remote-tracking branch 'origin/master' into stale-select
nolouch b658219
clean up
nolouch a06b1a3
Merge remote-tracking branch 'origin/master' into stale-select
nolouch 0f99648
update parser
nolouch c522744
address comments
nolouch 09e0a2e
Merge remote-tracking branch 'origin/master' into stale-select
nolouch 8446742
address comments
nolouch 03e8455
*: use preprocessor to get timestamp
xhebox 2c7113e
*: remove asofResolver, rename as WithPreprocessorReturn
xhebox 758fe74
use millisecond precision
nolouch d3c9647
*: fix tests
xhebox 11f2c16
*: fix remaining tests
xhebox aee7755
Merge branch 'master' into stale-select
nolouch 5d745ef
Merge remote-tracking branch 'origin/master' into stale-select
nolouch 3fa95e5
extract calculateTsExpr
nolouch 8ce9e5f
fix test
nolouch f0aefdc
update mod
nolouch 7e9a859
Merge branch 'master' into stale-select
xhebox e929ee6
Merge remote-tracking branch 'origin' into stale-select
nolouch 47c20b4
fix conflict
nolouch 6dbf8ef
try to fix test
nolouch ab2825b
address comment
nolouch 0fc6fb5
Merge remote-tracking branch 'origin/master' into stale-select
nolouch 4eeb62c
fix test
nolouch 58c3c0d
*: try to fix
xhebox 865db75
Merge remote-tracking branch 'pingcap/master' into stale_1
xhebox 880541b
try fix
nolouch c0b5145
add comment
nolouch 0713d8f
Merge branch 'master' into stale-select
nolouch c88bd2f
clean
nolouch 82674a7
Merge remote-tracking branch 'nolouch/stale-select' into stale-select
nolouch 36477da
try stable
nolouch 8fb38a1
address comment
nolouch e42f736
Merge branch 'master' into stale-select
nolouch 55966f9
Merge branch 'master' into stale-select
nolouch 0f56721
address comment
nolouch c7a8a96
Merge remote-tracking branch 'nolouch/stale-select' into stale-select
nolouch df4850f
Merge branch 'master' into stale-select
ti-chi-bot 6837ab5
Merge branch 'master' into stale-select
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should test this case:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let us handle it in another PR.