-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, executor: supports select statement with AS OF #24613
Conversation
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, expect that I am not sure if handles nested select stmt well. I doubt that it needs to be recursively called.
Signed-off-by: nolouch <[email protected]>
/run-all-tests |
/run-unit-test |
/run-sqllogic-test |
@JmPotato: Thanks for your review. The bot only counts In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: nolouch <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c7a8a96
|
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
@nolouch: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
/merge |
@nolouch: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@@ -1309,7 +1309,7 @@ func (s *testPlanSuite) TestVisitInfo(c *C) { | |||
stmt, err := s.ParseOneStmt(tt.sql, "", "") | |||
c.Assert(err, IsNil, comment) | |||
// to fix, Table 'test.ttt' doesn't exist | |||
_ = Preprocess(s.ctx, stmt, s.is) | |||
err = Preprocess(s.ctx, stmt, WithPreprocessorReturn(&PreprocessorReturn{InfoSchema: s.is})) | |||
builder, _ := NewPlanBuilder(MockContext(), s.is, &hint.BlockHintProcessor{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to check err
here.
Try run make check
before every commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, errcheck
will ignore test files.
Signed-off-by: nolouch [email protected]
What problem does this PR solve?
Ref: #24557
Problem Summary:
Implement the syntax
Select .... FROM xxx AS OF timestamp xxx
with stale read.What is changed and how it works?
the planner should visit the
as of
clause and extract the tso.Check List
Tests
Release note