Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: update memIndexLookUp to make it can read partition table correctly and add more cases about dynamic-mode with UnionScan #24877

Merged
merged 5 commits into from
May 25, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 25, 2021

What problem does this PR solve?

Issue Number: close #24150

Problem Summary: executor: update memIndexLookUp to make it can read partition table correctly and add more cases about dynamic-mode with UnionScan

What is changed and how it works?

executor: update memIndexLookUp to make it can read partition table correctly and add more cases about dynamic-mode with UnionScan.

Check List

Tests

  • Unit test

Release note

  • executor: update memIndexLookUp to make it can read partition table correctly and add more cases about dynamic-mode with UnionScan

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner sig/execution SIG execution labels May 25, 2021
@qw4990 qw4990 requested a review from a team as a code owner May 25, 2021 06:26
@qw4990 qw4990 requested review from XuHuaiyu and removed request for a team May 25, 2021 06:26
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2021
@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2021
Copy link
Contributor

@rebelice rebelice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented May 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 329dd37

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented May 25, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 681d8cc into pingcap:master May 25, 2021
@tisonkun
Copy link
Contributor

@qw4990 did this pr close #24150 accidentally? I think it is ref to the issue instead of closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone of Partition Table in Sprint3 (2021/4/19 ~ 2021/6/18)
5 participants