Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core/logical_plan_test.go: add error check #24942

Merged
merged 4 commits into from
May 27, 2021
Merged

planner/core/logical_plan_test.go: add error check #24942

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
546d4dd
wipe 🧻
ClSlaid May 27, 2021
651afd3
fix go mod
ClSlaid May 27, 2021
3f232d2
Merge branch 'master' of github.com:pingcap/tidb into water
ClSlaid May 27, 2021
efbc39d
ignore error
ClSlaid May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions planner/core/logical_plan_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,7 @@ func (s *testPlanSuite) TestVisitInfo(c *C) {
c.Assert(err, IsNil, comment)
// to fix, Table 'test.ttt' doesn't exist
err = Preprocess(s.ctx, stmt, WithPreprocessorReturn(&PreprocessorReturn{InfoSchema: s.is}))
c.Assert(err, IsNil, comment)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This err seems to need a fix rather than simply think it's nil here. (see the comment)

builder, _ := NewPlanBuilder(MockContext(), s.is, &hint.BlockHintProcessor{})
builder.ctx.GetSessionVars().SetHashJoinConcurrency(1)
_, err = builder.Build(context.TODO(), stmt)
Expand Down