planner/core/logical_plan_test.go: add error check #24942
Conversation
Signed-off-by: ClSlaid <[email protected]>
ti-chi-bot
added
the
size/XS
Signed-off-by: ClSlaid <[email protected]>
|
/run-check_dev_2 |
Signed-off-by: ClSlaid <[email protected]>
|
/run-all-tests |
planner/core/logical_plan_test.go
Outdated
| // to fix, Table 'test.ttt' doesn't exist | ||
| err = Preprocess(s.ctx, stmt, WithPreprocessorReturn(&PreprocessorReturn{InfoSchema: s.is})) | ||
| c.Assert(err, IsNil, comment) |
There was a problem hiding this comment.
This err seems to need a fix rather than simply think it's nil here. (see the comment)
|
/lgtm cancel |
|
|
Signed-off-by: ClSlaid <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: efbc39d
|
ti-chi-bot
added
the
status/can-merge
Signed-off-by: ClSlaid [email protected]
What problem does this PR solve?
fix
make check.Problem Summary:
an
errwas forgot to check, leading to a failure ofmake check.What is changed and how it works?
What's Changed:
How it Works:
Related changes
#24613
Check List
Tests
Side effects
no side effects
Release note
make check.