Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: enable dynamic mode for partition tables by default #25222

Closed
wants to merge 4 commits into from
Closed

planner: enable dynamic mode for partition tables by default #25222

wants to merge 4 commits into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 7, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: related to #24150

Problem Summary: planner: enable dynamic mode for partition tables by default

What is changed and how it works?

planner: enable dynamic mode for partition tables by default

Check List

Tests

  • Unit test

Release note

  • planner: enable dynamic mode for partition tables by default

@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 7, 2021
@qw4990 qw4990 requested a review from rebelice June 7, 2021 12:49
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qw4990 qw4990 requested a review from a team as a code owner June 7, 2021 12:49
@qw4990 qw4990 requested review from lzmhhh123 and removed request for a team June 7, 2021 12:49
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 7, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 7, 2021

WIP, some integration test cases may need to be updated.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 7, 2021

/run-tics-test

@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jun 7, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 8, 2021

Duplicated with #25255

@qw4990 qw4990 closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice Awaiting requested review from rebelice

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qw4990 @ti-chi-bot