-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: fix "data too long" error when dumping stats from table with new collation data (#27033) #27301
statistics: fix "data too long" error when dumping stats from table with new collation data (#27033) #27301
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@time-and-fate you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 022f96f
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #27033 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/27301
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #27024
When storing a histogram for a new collation column, we store its collate key instead of the original value.
However (1) when loading the histogram into stats cache, we try to convert the bounds of the histogram to the
FieldType
of this column (2) the collate key of a value is usually longer than the original value.So when doing the type conversion, the value may exceed the
FieldType.Flen
, which caused the "Data Too Long" error.What is changed and how it works?
When loading stats from storage into stats cache, for
String
values, no longer convert them to theFieldType
of this column.Now we always convert them to
TypeBlob
to bypass length checks.Check List
Tests
Side effects
Documentation
Release note