Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix "data too long" error when dumping stats from table with new collation data #27033

Merged
merged 9 commits into from
Aug 17, 2021

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Aug 9, 2021

What problem does this PR solve?

Issue Number: close #27024

When storing a histogram for a new collation column, we store its collate key instead of the original value.
However (1) when loading the histogram into stats cache, we try to convert the bounds of the histogram to the FieldType of this column (2) the collate key of a value is usually longer than the original value.
So when doing the type conversion, the value may exceed the FieldType.Flen, which caused the "Data Too Long" error.

What is changed and how it works?

When loading stats from storage into stats cache, for String values, no longer convert them to the FieldType of this column.
Now we always convert them to TypeBlob to bypass length checks.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2021
@time-and-fate
Copy link
Member Author

/sig planner
/component statistics

@github-actions github-actions bot added the sig/execution SIG execution label Aug 9, 2021
@time-and-fate
Copy link
Member Author

/run-check_dev_2

@ichn-hu ichn-hu mentioned this pull request Aug 9, 2021
@time-and-fate
Copy link
Member Author

/label needs-cherry-pick-5.2
/label needs-cherry-pick-5.1
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0

@ti-chi-bot
Copy link
Member

@time-and-fate: The label(s) needs-cherry-pick-5.2 cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label needs-cherry-pick-5.2
/label needs-cherry-pick-5.1
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@time-and-fate
Copy link
Member Author

/label needs-cherry-pick-5.2

@ti-chi-bot
Copy link
Member

@time-and-fate: The label(s) needs-cherry-pick-5.2 cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label needs-cherry-pick-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2021
@winoros
Copy link
Member

winoros commented Aug 17, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c571a37

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2021
@ti-chi-bot ti-chi-bot merged commit d06fd67 into pingcap:master Aug 17, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 17, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27299

@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27300

@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27301

@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27302

ti-chi-bot pushed a commit that referenced this pull request Sep 3, 2021
ti-chi-bot pushed a commit that referenced this pull request Sep 10, 2021
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
time-and-fate added a commit to time-and-fate/tidb that referenced this pull request Oct 12, 2021
zhouqiang-cl pushed a commit that referenced this pull request Oct 12, 2021
ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Data too long" error when dumping stats from a table with new collation
5 participants