-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: backup command with parameter s3 endpoint has suffix '/' #30138
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but i think the if len(qs.Endpoint) > 0
check is useless since TrimSuffix("", "/") == ""
anyway.
agreed, remove this check. |
Duplicate with #30144 , close this one. |
What problem does this PR solve?
backup failure when parameter s3 endpoint with suffix '/'
Issue Number: close #30104
Problem Summary:
AWS and mini support URL has suffix '/', however BR endpoint has suffix will failure.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note