Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: backup command with parameter s3 endpoint has suffix '/' #30138

Closed
wants to merge 39 commits into from

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Nov 25, 2021

What problem does this PR solve?

backup failure when parameter s3 endpoint with suffix '/'
Issue Number: close #30104

Problem Summary:
AWS and mini support URL has suffix '/', however BR endpoint has suffix will failure.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

fengou1 and others added 29 commits September 27, 2021 19:33
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2021
@fengou1 fengou1 added the component/br This issue is related to BR of TiDB. label Nov 25, 2021
br/pkg/backup/client.go Outdated Show resolved Hide resolved
br/pkg/summary/collector.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2021
br/pkg/storage/s3.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i think the if len(qs.Endpoint) > 0 check is useless since TrimSuffix("", "/") == "" anyway.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Nov 29, 2021

LGTM, but i think the if len(qs.Endpoint) > 0 check is useless since TrimSuffix("", "/") == "" anyway.

agreed, remove this check.

@kennytm kennytm mentioned this pull request Nov 30, 2021
12 tasks
@fengou1
Copy link
Contributor Author

fengou1 commented Nov 30, 2021

Duplicate with #30144 , close this one.

@fengou1 fengou1 closed this Nov 30, 2021
@fengou1 fengou1 deleted the issue_30104 branch December 12, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br s3 endpoint can't end with '/'
4 participants