Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix S3 backup endpoint suffix / #30144

Closed
wants to merge 4 commits into from
Closed

br: fix S3 backup endpoint suffix / #30144

wants to merge 4 commits into from

Conversation

tongtongyin
Copy link
Contributor

@tongtongyin tongtongyin commented Nov 25, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #30128

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Nov 25, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Nov 25, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@tongtongyin tongtongyin changed the title fix S3 backup endpoint suffix / br: fix S3 backup endpoint suffix / Nov 25, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2021
@kennytm kennytm added the component/br This issue is related to BR of TiDB. label Nov 30, 2021
kennytm
kennytm reviewed Nov 30, 2021
View reviewed changes
br/pkg/storage/s3.go
@@ -189,6 +189,7 @@ func (options *S3BackendOptions) parseFromFlags(flags *pflag.FlagSet) error {
if err != nil {
return errors.Trace(err)
}
options.Endpoint = strings.Trim(options.Endpoint, "/")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
options.Endpoint = strings.Trim(options.Endpoint, "/")
options.Endpoint = strings.TrimSuffix(options.Endpoint, "/")

@fengou1 fengou1 mentioned this pull request Nov 30, 2021
Closed
12 tasks
kennytm
kennytm reviewed Nov 30, 2021
View reviewed changes
ddl/options_test.go
@@ -15,22 +15,21 @@
package ddl_test

import (
"github.com/stretchr/testify/require"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[2021-11-30T08:07:27.397Z] ddl/options_test.go:18: File is not `goimports`-ed (goimports)
[2021-11-30T08:07:27.397Z] 	"github.com/stretchr/testify/require"

let's not do the test-infra migration in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

fengou1
fengou1 reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@fengou1 fengou1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we try to get flag s3.endpoint, what if -s "s3://bank/shenma-without-stats?access-key=admin&secret-access-key=Passadmin&endpoint=http://minio.pingcap.net:9000/&force-path-style=true"

@ti-chi-bot
Copy link
Member

@tongtongyin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021
@tongtongyin
Copy link
Contributor Author

I resubmitted a PR and closed the current one

@tongtongyin
Copy link
Contributor Author

#30530

@kennytm kennytm closed this Dec 9, 2021
@kennytm kennytm mentioned this pull request Dec 9, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengou1 fengou1 fengou1 left review comments

@kennytm kennytm kennytm left review comments

Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

During S3 backup, errors may occur if there is "/" at the end of the endpoint
5 participants
@tongtongyin @ti-chi-bot @sre-bot @kennytm @fengou1