Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: restrict plan cache for decimal parameter types #31769

Merged
merged 7 commits into from
Mar 29, 2022
Merged

planner: restrict plan cache for decimal parameter types #31769

merged 7 commits into from
Mar 29, 2022

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #31730
ref #29565

Problem Summary:
The results are different if decimal column exist some larger value

What is changed and how it works?

For the decimal type, we can only use the plan when both Flen and Decimal should be less equal than the cached one.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent added type/bugfix This PR fixes a bug. sig/planner SIG: Planner epic/plan-cache labels Jan 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 19, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f196fe276de45e759740b78a0d279afc73d7b550

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2022
winoros
winoros reviewed Mar 21, 2022
View reviewed changes
planner/core/cache.go
@@ -172,6 +172,11 @@ func (s FieldSlice) Equal(tps []*types.FieldType) bool {
(s[i].EvalType() == types.ETInt && mysql.HasUnsignedFlag(s[i].Flag) != mysql.HasUnsignedFlag(tps[i].Flag)) {
return false
}
// When the type is decimal, we should compare the Flen and Decimal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we call the FieldSlice.Equal?

Copy link
Contributor Author

@Reminiscent Reminiscent Mar 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only used in Execute.getPhysicalPlan in planner/core package for plan cache.
Besides the comments for the function in line158 says Currently this is only used in plan cache to invalidate cache when types of variables are different.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f196fe2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@ti-chi-bot ti-chi-bot merged commit eec5186 into pingcap:master Mar 29, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Reminiscent @ti-srebot
cherry pick pingcap#31769 to release-5.3
e588e5f 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33542

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Reminiscent @ti-srebot
cherry pick pingcap#31769 to release-5.4
23e4547 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33543

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Reminiscent @ti-srebot
cherry pick pingcap#31769 to release-6.0
76fb4fa 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
epic/plan-cache needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plan-cache: the results is different if decimal column exist some larger value
6 participants
@Reminiscent @ti-chi-bot @sre-bot @ti-srebot @winoros @time-and-fate