-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: restrict plan cache for decimal parameter types (#31769) #33543
base: release-5.4
Are you sure you want to change the base?
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@Reminiscent you're already a collaborator in bot's repo. |
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-pick #31769 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33543
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #31730
ref #29565
Problem Summary:
The results are different if decimal column exist some larger value
What is changed and how it works?
For the
decimal
type, we can only use the plan when both Flen and Decimal should be less equal than the cached one.Check List
Tests
Side effects
Documentation
Release note