Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add show push down for ShowTables #31919

Merged
merged 13 commits into from
Jan 26, 2022
Merged

*: add show push down for ShowTables #31919

merged 13 commits into from
Jan 26, 2022

Conversation

hawkingrei
Copy link
Member

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #30803

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cf0d9ab8afd33c4717c026052aadb1cd6ab16412

@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 24, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-check_dev

zimulala
zimulala reviewed Jan 26, 2022
View reviewed changes
planner/core/show_predicate_extractor.go Outdated
// It is used in `SHOW TABLE in t LIKE `abc``.
ptn := pattern.Pattern.(*driver.ValueExpr).GetString()
patValue, patTypes := stringutil.CompilePattern(ptn, pattern.Escape)
if !collate.NewCollationEnabled() && stringutil.IsExactMatch(patTypes) {
Copy link
Contributor

@zimulala zimulala Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand. Why do you need this logic of !collate.NewCollationEnabled()? Please help to explain it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is copied from planner/core/expression_rewriter.go:1634.

Treat predicate 'like' the same way as predicate '=' when it is an exact match and new collation is not enabled.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could remove this if statement, then use CompileLike2Regexp directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will remove NewCollationEnabled condition. but IsExactMatch still retained. Equal is faster than regexp.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

hawkingrei and others added 7 commits January 26, 2022 16:47
zimulala
zimulala approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2022
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8245dc2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@ti-chi-bot ti-chi-bot merged commit 93454da into pingcap:master Jan 26, 2022
@hawkingrei hawkingrei added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 23, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 23, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#31919 to release-5.4
ab5fc46 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33338

ti-chi-bot pushed a commit that referenced this pull request Mar 31, 2022
@ti-srebot
*: add show push down for ShowTables (#31919) (#33338)
b1c5a67 
close #30803
This was referenced May 24, 2022
Closed
Closed
e1ijah1
e1ijah1 reviewed May 24, 2022
View reviewed changes
executor/show.go
// Test with mysql.AllPrivMask means any privilege would be OK.
// TODO: Should consider column privileges, which also make a table visible.
if checker != nil && !checker.RequestVerification(activeRoles, e.DBName.O, v.Meta().Name.O, "", mysql.AllPrivMask) {
continue
} else if FieldFilterEnable && v.Meta().Name.L != fieldFilter {
continue
} else if fieldPatternsRegexp != nil && !fieldPatternsRegexp.MatchString(v.Meta().Name.L) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. Can we use the original string of meta info instead of the lower case string to match the pattern? Plz help to explain it. @hawkingrei

@likzn likzn mentioned this pull request May 31, 2022
Merged
12 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 1, 2022
Closed
12 tasks
@likzn likzn mentioned this pull request Jun 6, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e1ijah1 e1ijah1 e1ijah1 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@zimulala zimulala zimulala approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show tables Compatibility differences
7 participants
@hawkingrei @ti-chi-bot @sre-bot @zimulala @ti-srebot @tiancaiamao @e1ijah1