Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: make output field name in show tables/databases stmt compatible with mysql #35136

Merged
merged 19 commits into from
Jun 29, 2022
Merged

ddl: make output field name in show tables/databases stmt compatible with mysql #35136

merged 19 commits into from
Jun 29, 2022

Conversation

likzn
Copy link
Contributor

@likzn likzn commented Jun 2, 2022

What problem does this PR solve?

Issue Number: close #35116

Problem Summary: SHOW TABLES/DATABASES ... LIKE ..., the output field is a little different with Mysql.

QUERY >	 SHOW TABLES LIKE 'apigw_routes'
TiDB  >
+-------------------+
| Tables_in_corteza |
+-------------------+
| apigw_routes      |
+-------------------+
MySQL >
+----------------------------------+
| Tables_in_corteza (apigw_routes) |
+----------------------------------+
| apigw_routes                     |
+----------------------------------+

And the mysql will add PatternLikeName at the behind when we use like. If we do not use like, the behavior is the same.

Ref in Mysql: https://github.com/mysql/mysql-server/blob/3e90d07c3578e4da39dc1bce73559bbdf655c28c/sql/dd/info_schema/show.cc#L537-L545

What is changed and how it works?

  1. When we buildShowSchema, format field name with PatternLikeExpr to be compatible with Mysql.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Make output field name in statement of `show tables/databases` compatible with mysql

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2022
@likzn
Copy link
Contributor Author

likzn commented Jun 2, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9e9a37191ab9631b7998df055d755b9f1ec80a00

@likzn
Copy link
Contributor Author

likzn commented Jun 2, 2022

/cc @hawkingrei @xiongjiwei @xhebox

@likzn
Copy link
Contributor Author

likzn commented Jun 2, 2022

PTAL if free. By the way, how to join the slack of tidb-community? I input the email, but nothing response. And i also post in the AskAug https://asktug.com/t/topic/693265. But nobody reply yet

@xhebox
Copy link
Contributor

xhebox commented Jun 6, 2022 •
edited
Loading

PTAL if free. By the way, how to join the slack of tidb-community? I input the email, but nothing response. And i also post in the AskAug https://asktug.com/t/topic/693265. But nobody reply yet

Should receive one email if you join the slack. Maybe in the trash.

@likzn
Copy link
Contributor Author

likzn commented Jun 6, 2022 •
edited
Loading

PTAL if free. By the way, how to join the slack of tidb-community? I input the email, but nothing response. And i also post in the AskAug https://asktug.com/t/topic/693265. But nobody reply yet

Should receive one email if you join the slack. Maybe in the trash.

It is strange. I had recived no email about slack.. Trash is also checked.

bb7133
bb7133 reviewed Jun 6, 2022
View reviewed changes
planner/core/planbuilder.go
p.Extractor = extractor
// Avoid building Selection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why removing show.Pattern = nil a little bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is introduced in #31919 to fix case insentive with some show statment. It mean if we have newShowBaseExtractor , we will not build show.Pattern in line 3015. But in this case, we need extract patternLikeName in show.Pattern. So i remove it and add an extra check in line 3015 to make them behave same.

Copy link
Contributor

@xhebox xhebox Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safer to mark an extra flag like noShowPattern or somethine similar. There are some other extractors that may be introduced later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. An extra flag is more clearer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. An extra flag is more clearer.

You don't need to add it to LogicalShow struct, a variable in buildShow is enough 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. Just finished exercise, my head is a little dizzy

@likzn likzn requested review from bb7133 and tangenta June 7, 2022 12:19
@likzn
Copy link
Contributor Author

likzn commented Jun 10, 2022

Has any friend take a look about this

@likzn
Copy link
Contributor Author

likzn commented Jun 14, 2022

/cc @wjhuang2016 @morgo

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ce665e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2022
@likzn
Copy link
Contributor Author

likzn commented Jun 28, 2022

/run-check_dev_2

@likzn
Copy link
Contributor Author

likzn commented Jun 28, 2022

/run-mysql-test

@xhebox
Copy link
Contributor

xhebox commented Jun 29, 2022

/hold

I think there is a stable test failure, @likzn , I'll take a look.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2022
@likzn
Copy link
Contributor Author

likzn commented Jun 29, 2022

It is introduced by this PR. Error Message:

show databases like "test%";:
NEED: show tables like 't_';\nTables_in_lowercase_table\nT3\nt4\ndrop \n
BUT GOT: show tables like 't_';\nTables_in_lowercase_table (t_)\nT3\nt4\n\n"

The difference of them is the output field name. But i cant find where the mysql_test is. And i find test result in mysql is below https://github.com/mysql/mysql-server/blob/8d8c986e5716e38cb776b627a8eee9e92241b4ce/mysql-test/r/lowercase_table.result#L29-L32.
image

@tangenta
Copy link
Contributor

/run-mysql-test tidb-test=pr/1853

@tangenta
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2022
@ti-chi-bot ti-chi-bot merged commit 9bde478 into pingcap:master Jun 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 29, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 2, success 10, total 12 12 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 18 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 16 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 40 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 59 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 28 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 13 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jun 29, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into remove-hidden-sys…
a104dff 
…vars

* upstream/master: (28 commits)
  *: enable unconvert (pingcap#35821)
  log-backup: check timezone when using datatime format ts string (pingcap#35811)
  planner: support the leading hint for outer join (pingcap#35264)
  lightning: revert new policy of allocating rowid and refine it later (pingcap#35817)
  txn: manage the initialization of RCCheckTS by transaction context provider (pingcap#35554)
  ddl: make output field name in `show tables/databases stmt` compatible with mysql (pingcap#35136)
  txn: remove `legacy.SimpleTxnContextProvider` (pingcap#35667)
  txn: fix the error message if retry could not be used for rc check ts (pingcap#35474)
  *: support canceling DDL statements with KILL (pingcap#35803)
  lightning: avoid extracting db schema when schema file is not provided (pingcap#35783)
  *: enable all gosimples (pingcap#35762)
  tools/check: skip 'tests' directory in 'make ut' (pingcap#35800)
  metrics: add loading region cache duration (pingcap#34679)
  ddl: DROP TABLE/VIEW/SEQUENCE now use XXXStmt as parameter (pingcap#35741)
  types: fix incompatible implementation of jsonpath extraction (pingcap#35320)
  planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743)
  *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746)
  sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703)
  helper: request another PD if one of them is unavailable (pingcap#35750)
  metrics: add cached table related metrics to grafana panel (pingcap#34718)
  ...
@lance6716 lance6716 mentioned this pull request Jun 30, 2022
Merged
@tangenta tangenta mentioned this pull request Jul 22, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@tangenta tangenta tangenta approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@bb7133 bb7133 Awaiting requested review from bb7133

@morgo morgo Awaiting requested review from morgo

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a little different in the field name with SHOW TABLES LIKE with MySQL and TiDB
7 participants
@likzn @ti-chi-bot @sre-bot @xhebox @tangenta @bb7133 @hawkingrei