Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: tolerate tikv node address changes during importing #32876

Merged
merged 16 commits into from
Mar 15, 2022
Merged

lightning: tolerate tikv node address changes during importing #32876

merged 16 commits into from
Mar 15, 2022

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Mar 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32875

Problem Summary:

Lightning cannot restore successfully while tikv store address changes.

What is changed and how it works?

  1. Implement custom gRPC resolver.
  2. Increase the max retry times for write and ingest.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

lightning: tolerate tikv node address changes during importing

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d5b4dfe6cb8cf1e7173dda1d0e137c1da719337c

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2022
@sleepymole sleepymole marked this pull request as ready for review March 8, 2022 09:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2022
@sleepymole
Copy link
Contributor Author

/component lightning
/cc @glorv @kennytm

@ti-chi-bot ti-chi-bot requested review from glorv and kennytm March 8, 2022 09:32
@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Mar 8, 2022
glorv
glorv reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

br/pkg/lightning/backend/local/local.go Outdated Show resolved Hide resolved
br/pkg/lightning/backend/local/local.go Outdated Show resolved Hide resolved
br/pkg/resolver/resolver.go Show resolved Hide resolved
glorv
glorv approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels Mar 10, 2022
lichunzhu
lichunzhu approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

br/pkg/lightning/backend/local/local.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2022
@sleepymole
Copy link
Contributor Author

/run-integration-br-test

@glorv
Copy link
Contributor

glorv commented Mar 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7af536b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot ti-chi-bot merged commit 9c4f94d into pingcap:master Mar 15, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 15, 2022
@sleepymole @ti-srebot
cherry pick pingcap#32876 to release-5.2
c6b8a92 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 15, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33105

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 15, 2022
@sleepymole @ti-srebot
cherry pick pingcap#32876 to release-5.3
bb07246 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 15, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33106

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 15, 2022
@sleepymole @ti-srebot
cherry pick pingcap#32876 to release-5.4
591b8a7 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 15, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33107

@sleepymole sleepymole mentioned this pull request Mar 16, 2022
Merged
12 tasks
@sleepymole sleepymole deleted the issue-32875 branch March 16, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@glorv glorv glorv approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: restore failed while store address changes
6 participants
@sleepymole @ti-chi-bot @sre-bot @glorv @ti-srebot @lichunzhu