Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: tolerate tikv node address changes during importing (#32876) #33107

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 15, 2022

cherry-pick #32876 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33107

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33107:release-5.4-9c4f94dd7001

What problem does this PR solve?

Issue Number: close #32875

Problem Summary:

Lightning cannot restore successfully while tikv store address changes.

What is changed and how it works?

  1. Implement custom gRPC resolver.
  2. Increase the max retry times for write and ingest.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

lightning: tolerate tikv node address changes during importing 

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2022
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.4-cherry-pick labels Mar 15, 2022
@ti-srebot
Copy link
Contributor Author

@gozssky you're already a collaborator in bot's repo.

@sleepymole
Copy link
Contributor

/close

@ti-chi-bot
Copy link
Member

@gozssky: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot closed this Mar 16, 2022
@sleepymole sleepymole deleted the release-5.4-9c4f94dd7001 branch March 16, 2022 05:57
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 17, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/lightning This issue is related to Lightning of TiDB. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants