-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: check DDL history job in test #33079
Conversation
Signed-off-by: wjhuang2016 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-test |
1 similar comment
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/90f9fe706ef88562d3bf387f34f3ebdef068034c |
Signed-off-by: wjhuang2016 <[email protected]>
…add_check_in_test
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
Signed-off-by: wjhuang2016 <[email protected]>
@@ -610,13 +611,62 @@ func recordLastDDLInfo(ctx sessionctx.Context, job *model.Job) { | |||
ctx.GetSessionVars().LastDDLInfo.SeqNum = job.SeqNum | |||
} | |||
|
|||
func checkHistoryJobInTest(ctx sessionctx.Context, historyJob *model.Job) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put it to ddl_test.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's called during the normal logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a0d8b80
|
@wjhuang2016: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: wjhuang2016 [email protected]
What problem does this PR solve?
Issue Number: ref #33078, and fix #33134
Problem Summary:
Do some checks for complete/rollback DDL job.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note