Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check DDL history job in test #33079

Merged
merged 13 commits into from
Mar 17, 2022
Merged

ddl: check DDL history job in test #33079

merged 13 commits into from
Mar 17, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Mar 15, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

Issue Number: ref #33078, and fix #33134

Problem Summary:
Do some checks for complete/rollback DDL job.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
a4d8805 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2022
@wjhuang2016
Copy link
Member Author

/run-unit-test

1 similar comment
@wjhuang2016
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/90f9fe706ef88562d3bf387f34f3ebdef068034c

@wjhuang2016
fix
d1f55ce 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
Merge branch 'add_check_in_test' of github.com:wjhuang2016/tidb into …
b84dbd0 
…add_check_in_test
@wjhuang2016
fix for create tables
07fb277 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
done
6d73b09 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022
@wjhuang2016
fix
f55b0f8 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
fix
1e181bb 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2022
@wjhuang2016 wjhuang2016 mentioned this pull request Mar 16, 2022
Closed
@wjhuang2016
fix
62b55a5 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
refine comment
c33e886 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
fix test
b11203c 
Signed-off-by: wjhuang2016 <[email protected]>
crazycs520
crazycs520 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@wjhuang2016
Copy link
Member Author

/run-unit-test

@wjhuang2016
fix test
a0d8b80 
Signed-off-by: wjhuang2016 <[email protected]>
zimulala
zimulala reviewed Mar 17, 2022
View reviewed changes
ddl/ddl.go
@@ -610,13 +611,62 @@ func recordLastDDLInfo(ctx sessionctx.Context, job *model.Job) {
ctx.GetSessionVars().LastDDLInfo.SeqNum = job.SeqNum
}

func checkHistoryJobInTest(ctx sessionctx.Context, historyJob *model.Job) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put it to ddl_test.go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's called during the normal logic.

zimulala
zimulala approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a0d8b80

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@ti-chi-bot
Copy link
Member

@wjhuang2016: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f950b21 into pingcap:master Mar 17, 2022
@lance6716 lance6716 mentioned this pull request Mar 18, 2022
Open
@wjhuang2016 wjhuang2016 deleted the add_check_in_test branch November 17, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some DDL queries are written incorrectly
5 participants
@wjhuang2016 @ti-chi-bot @sre-bot @zimulala @crazycs520