Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance the testability of DDL #33078

Open
wjhuang2016 opened this issue Mar 15, 2022 · 2 comments
Open

enhance the testability of DDL #33078

wjhuang2016 opened this issue Mar 15, 2022 · 2 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wjhuang2016
Copy link
Member

Enhancement

This issue tracks some PRs which enhance the testability of DDL.
@wjhuang2016 wjhuang2016 added the type/enhancement The issue or PR belongs to an enhancement. label Mar 15, 2022
@wjhuang2016 wjhuang2016 mentioned this issue Mar 15, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 17, 2022
@wjhuang2016
ddl: check DDL history job in test (#33079)
f950b21 
ref #33078, fix #33134
@lance6716
Copy link
Contributor

lance6716 commented Mar 18, 2022 •
edited
Loading

Will #33079 be reverted soon or exist for a long time? DM directly uses DDL API and now needs to set "skip" query string. Not sure if I'll revert setting query string soon

DM's upgrading dependency PR pingcap/tiflow#4949

@wjhuang2016
Copy link
Member Author

Will #33079 be reverted soon or exist for a long time? DM directly uses DDL API and now needs to set "skip" query string. Not sure if I'll revert setting query string soon

DM's upgrading dependency PR pingcap/tiflow#4949

It's not planned to revert, and more checks will be added soon.

@wjhuang2016 wjhuang2016 mentioned this issue Mar 24, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 1, 2022
@wjhuang2016
ddl: check delete range for some DDLs (#33392)
d0bf65c 
ref #33078
@tangenta tangenta mentioned this issue Jun 30, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 1, 2022
@tangenta
sanity_check: adapt checkDeleteRangeCnt() for multi-schema change (#…
ea5b0ff 
…35870)

ref #33078, ref #33392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lance6716 @wjhuang2016