Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topsql: enable topsql feature by default #33195

Merged
merged 8 commits into from
Mar 17, 2022
Merged

topsql: enable topsql feature by default #33195

merged 8 commits into from
Mar 17, 2022

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 [email protected]

What problem does this PR solve?

Issue Number: close #33194

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None

@crazycs520 crazycs520 requested a review from a team as a code owner March 17, 2022 05:47
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2022
breezewish
breezewish approved these changes Mar 17, 2022
View reviewed changes
session/bootstrap.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9d0f08c56ffcc5af078d6704d3e4b5ed94d9f452

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@crazycs520
Copy link
Contributor Author

/run-all-tests

bb7133
bb7133 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Mar 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 038417f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9d0f08c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@ti-chi-bot ti-chi-bot merged commit 44cf398 into pingcap:master Mar 17, 2022
@breezewish
Copy link
Member

/merge

@crazycs520 crazycs520 deleted the enable-topsql branch March 17, 2022 07:28
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Mar 28, 2022
@crazycs520
Revert "topsql: enable topsql feature by default (pingcap#33195)"
09a1a66 
This reverts commit 44cf398.
ti-chi-bot pushed a commit that referenced this pull request Mar 28, 2022
@crazycs520
Revert "topsql: enable topsql feature by default (#33195)" (#33493)
5c931aa 
close #33492
ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2022
@ti-srebot
Revert "topsql: enable topsql feature by default (#33195)" (#33493) (#…
6f28ac4 
…33522)

close #33492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@breezewish breezewish breezewish approved these changes

@zhongzc zhongzc zhongzc approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable topsql feature by default
6 participants
@crazycs520 @ti-chi-bot @sre-bot @bb7133 @breezewish @zhongzc