Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topsql: fix the issue of TiDB doesn't set the request tag for DDL before send RPC request to TiKV (#33133) #33210

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 17, 2022

cherry-pick #33133 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33210

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33210:release-5.4-e8ee6c193948

What problem does this PR solve?

Issue Number: close #33132

Problem Summary: This PR fix the issue of TiDB doesn't set the request tag for DDL before send rpc to TiKV.

What is changed and how it works?

Set the DDL request tag.

Other problem: After this PR, TopSQL still doesn't contain the scan_row/scan_index data , I will fix this in next PR.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. create a table and insert 10000000 rows data.
CREATE TABLE `t_full_table_scan` (
  `a` bigint(20) NOT NULL,
  `b` bigint(20) DEFAULT NULL,
  `c` timestamp(6) NULL DEFAULT NULL,
  `d` varchar(100) DEFAULT NULL,
  `e` decimal(30,8) DEFAULT NULL,
  PRIMARY KEY (`a`)
);
  1. execute following DDL:
alter table t_full_table_scan add index idx2 (c,d,b);
alter table t_full_table_scan modify column e decimal(30, 8);
  1. check the topsql UI in tidb-dashboard.

TiDB:
image

TiKV:
image

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 17, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.4-cherry-pick labels Mar 17, 2022
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2022
@ti-srebot
Copy link
Contributor Author

@crazycs520 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 17, 2022
@breezewish
Copy link
Member

This is not a critical issue in 5.4.0. Closing.

@breezewish breezewish closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants