Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege/privileges, server: stabalize tests #33246

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 18, 2022

What problem does this PR solve?

Issue Number: close #33245

Problem Summary:

The server test tries to listen on port 4000 / 10080 which are the defaults. So if TiDB is running on the same system it will fail (seems pretty common this might be the case on a developer machine).

The privileges test has leaks. It might be related to the go 1.18 upgrade since nothing has changed.. but it could also be a race that is now common since I had previously seen these errors but they went away.

What is changed and how it works?

Fixed tests only.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2022
@morgo morgo requested a review from mjonss March 18, 2022 18:42
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 19, 2022
@ngaut
Copy link
Member

ngaut commented Mar 19, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 21968fa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit a3a1e01 into pingcap:master Mar 21, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 21, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33274

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 21, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable tests in server and privilege/privileges
6 participants