privilege/privileges, server: stabalize tests (#33246) #33274
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/cherry-pick-not-approved
do-not-merge/release-note-label-needed
|
/run-all-tests |
ti-chi-bot
added
release-note-none
ti-srebot
added
size/XS
12 tasks
|
@morgo you're already a collaborator in bot's repo. |
hawkingrei
approved these changes
Mar 28, 2022
ti-chi-bot
added
status/LGT2
VelocityLight
added
cherry-pick-approved
VelocityLight
added
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #33246 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33274After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #33245
Problem Summary:
The server test tries to listen on port 4000 / 10080 which are the defaults. So if TiDB is running on the same system it will fail (seems pretty common this might be the case on a developer machine).
The privileges test has leaks. It might be related to the go 1.18 upgrade since nothing has changed.. but it could also be a race that is now common since I had previously seen these errors but they went away.
What is changed and how it works?
Fixed tests only.
Check List
Tests
Side effects
Documentation
Release note