Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add testcase to cover stale read and prepare stmt #33270

Merged
merged 3 commits into from
Mar 21, 2022
Merged

executor: add testcase to cover stale read and prepare stmt #33270

merged 3 commits into from
Mar 21, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Mar 21, 2022 •
edited
Loading

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: ref #31550

Problem Summary:

What is changed and how it works?

The bug is fixed, this requests add a testcase to cover it.

Check List

Tests

  • Unit test

Release note

None

@Yisaer
add testcase
a6c190f 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2022
@Yisaer
add testcase
b4211ef 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 21, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/125b54cbc9cc31b70b092d4a5333309f280a203b

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022
@lcwangchao
Copy link
Collaborator

The testcase if fine. But it seems not resolved the issue #31550

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 21, 2022

The testcase if fine. But it seems not resolved the issue #31550

If the sql result is ok, I think the origin issue can't be thought as a bug as users won't face it.

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b4211ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 0d160fb into pingcap:master Mar 21, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 21, 2022
@Yisaer @ti-srebot
cherry pick pingcap#33270 to release-6.0
295a519 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 21, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33272

ti-chi-bot pushed a commit that referenced this pull request Mar 28, 2022
@ti-srebot
executor: add testcase to cover stale read and prepare stmt (#33270) (#…
953b420 
…33272)

ref #31550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Yisaer @ti-chi-bot @sre-bot @lcwangchao @hawkingrei @ti-srebot @JmPotato