Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr: switch off left push down due to intergration test failed #33302

Merged
merged 45 commits into from
Mar 22, 2022
Merged
Show file tree
Hide file tree
Changes from 42 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
1a513b7
fix
Yisaer Sep 27, 2021
eb4a6a0
Merge branch 'master' into fix_follower_read_closest_read
Yisaer Sep 27, 2021
7ab3887
Merge remote-tracking branch 'upstream/master' into fix_follower_read…
Yisaer Sep 27, 2021
46e1081
fix
Yisaer Sep 27, 2021
b62b16e
fix
Yisaer Sep 27, 2021
061a77a
fix test
Yisaer Sep 27, 2021
67cf993
fix test
Yisaer Sep 27, 2021
909272e
fix test
Yisaer Sep 27, 2021
a4bc015
Merge branch 'master' into fix_follower_read_closest_read
ti-chi-bot Sep 28, 2021
29e164e
support forward dumpfile request
Yisaer Nov 1, 2021
cd3892b
fix lint
Yisaer Nov 1, 2021
f9f2aa1
fix lint
Yisaer Nov 1, 2021
116501c
fix lint
Yisaer Nov 1, 2021
eb1d8be
Merge branch 'master' into support_forward_replayer
ti-chi-bot Nov 2, 2021
909a78a
Merge branch 'master' into support_forward_replayer
ti-chi-bot Nov 2, 2021
8c73ad9
Merge remote-tracking branch 'upstream/master'
Yisaer Nov 2, 2021
5794923
Merge branch 'support_forward_replayer' of https://github.com/yisaer/…
Yisaer Nov 2, 2021
31bfca4
Merge branch 'fix_follower_read_closest_read' of https://github.com/y…
Yisaer Nov 2, 2021
9450776
Merge remote-tracking branch 'upstream/master'
Yisaer Dec 13, 2021
9ef26e0
Merge remote-tracking branch 'upstream/master'
Yisaer Dec 20, 2021
14752ee
Merge remote-tracking branch 'upstream/master'
Yisaer Dec 23, 2021
6d78c27
Merge remote-tracking branch 'upstream/master'
Yisaer Dec 27, 2021
2be2b07
Merge remote-tracking branch 'upstream/master'
Yisaer Dec 29, 2021
cb1c8bf
Merge remote-tracking branch 'upstream/master'
Yisaer Jan 4, 2022
6e72c03
Merge remote-tracking branch 'upstream/master'
Yisaer Jan 6, 2022
9fe4957
Merge remote-tracking branch 'upstream/master'
Yisaer Jan 11, 2022
1c30e47
Merge remote-tracking branch 'upstream/master'
Yisaer Jan 20, 2022
db4bf04
Merge remote-tracking branch 'upstream/master'
Yisaer Jan 21, 2022
2a7cea8
Merge remote-tracking branch 'upstream/master'
Yisaer Jan 25, 2022
25a10b3
Merge remote-tracking branch 'upstream/master'
Yisaer Jan 28, 2022
2f5ffbb
Merge remote-tracking branch 'upstream/master'
Yisaer Feb 7, 2022
5f3327c
Merge remote-tracking branch 'upstream/master'
Yisaer Feb 11, 2022
f2e9ea3
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 2, 2022
8d3cf93
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 3, 2022
6e408f9
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 8, 2022
110f0ee
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 15, 2022
2803afe
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 17, 2022
67f7330
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 18, 2022
a7a48f1
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 21, 2022
9c51c36
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 21, 2022
81a71d6
Merge remote-tracking branch 'upstream/master'
Yisaer Mar 22, 2022
5d42a6e
switch off left push down
Yisaer Mar 22, 2022
a11a9df
Merge branch 'master' into ref_32739
Yisaer Mar 22, 2022
d7a5cc1
fix test
Yisaer Mar 22, 2022
6dea31d
fix test
Yisaer Mar 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions expression/expr_to_pb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1246,11 +1246,6 @@ func TestExprPushDownToTiKV(t *testing.T) {
retType: types.NewFieldType(mysql.TypeString),
args: []Expression{stringColumn, intColumn},
},
{
functionName: ast.Left,
retType: types.NewFieldType(mysql.TypeString),
args: []Expression{stringColumn, intColumn},
},
{
functionName: ast.Sin,
retType: types.NewFieldType(mysql.TypeDouble),
Expand Down
2 changes: 1 addition & 1 deletion expression/expression.go
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ func scalarExprSupportedByTiKV(sf *ScalarFunction) bool {
ast.Length, ast.BitLength, ast.Concat, ast.ConcatWS, ast.Replace, ast.ASCII, ast.Hex,
ast.Reverse, ast.LTrim, ast.RTrim, ast.Strcmp, ast.Space, ast.Elt, ast.Field,
InternalFuncFromBinary, InternalFuncToBinary, ast.Mid, ast.Substring, ast.Substr, ast.CharLength,
ast.Right, ast.Left,
ast.Right, /* ast.Left */

// json functions.
ast.JSONType, ast.JSONExtract, ast.JSONObject, ast.JSONArray, ast.JSONMerge, ast.JSONSet,
Expand Down
4 changes: 0 additions & 4 deletions planner/core/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2771,10 +2771,6 @@ func TestScalarFunctionPushDown(t *testing.T) {
tk.MustQuery("explain analyze select /*+read_from_storage(tikv[t])*/ * from t where right(c,1);").
CheckAt([]int{0, 3, 6}, rows)

rows[1][2] = "left(test.t.c, 1)"
tk.MustQuery("explain analyze select /*+read_from_storage(tikv[t])*/ * from t where left(c,1);").
CheckAt([]int{0, 3, 6}, rows)

rows[1][2] = "mod(test.t.id, test.t.id)"
tk.MustQuery("explain analyze select /*+read_from_storage(tikv[t])*/ * from t where mod(id, id);").
CheckAt([]int{0, 3, 6}, rows)
Expand Down