Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr: switch off left push down due to intergration test failed #33302

Merged
merged 45 commits into from
Mar 22, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Mar 22, 2022

What problem does this PR solve?

Issue Number: close #33255 #33256

Problem Summary:

What is changed and how it works?

switch off left push down due to intergration test failed which block 6.0 release. After we find out bug, we will switch on left push down again

I run mysql-test with this request, the result is expected.

$ ./mysql_test -host 127.0.0.1 -port 4000 -user root -params '&allowNativePasswords=true&allowAllFiles=true' index_merge_sqlgen_exprs_orandor_1_no_out_trans
INFO[0000] running tests: [index_merge_sqlgen_exprs_orandor_1_no_out_trans] 
WARN[0000] Create new db&{0 0xc0000b2000 0 {0 0} [0xc0000be000] map[] 0 1 0xc0000b4000 false map[0xc0000be000:map[0xc0000be000:true]] map[] 0 0 0 0 <nil> 0 0 0 0 0x1088dc0} 
./t/index_merge_sqlgen_exprs_orandor_1_no_out_trans.test: ok! 10173 test cases passed, take time 23.954630325 s
INFO[0024] run test [index_merge_sqlgen_exprs_orandor_1_no_out_trans] ok 
$ ./mysql_test -host 127.0.0.1 -port 4000 -user root -params '&allowNativePasswords=true&allowAllFiles=true' index_merge_sqlgen_exprs
INFO[0000] running tests: [index_merge_sqlgen_exprs]    
WARN[0000] Create new db&{0 0xc000010090 0 {0 0} [0xc00013a6c0] map[] 0 1 0xc000102180 false map[0xc00013a6c0:map[0xc00013a6c0:true]] map[] 0 0 0 0 <nil> 0 0 0 0 0x1088dc0} 
./t/index_merge_sqlgen_exprs.test: ok! 533 test cases passed, take time 2.163011253 s
INFO[0002] run test [index_merge_sqlgen_exprs] ok  

Check List

Tests

  • Unit test

Release note

None

Yisaer and others added 30 commits September 27, 2021 13:08
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>

add log

Signed-off-by: yisaer <[email protected]>

add log

Signed-off-by: yisaer <[email protected]>

add log

Signed-off-by: yisaer <[email protected]>

add log

Signed-off-by: yisaer <[email protected]>

fix get topo

Signed-off-by: yisaer <[email protected]>

revise log

Signed-off-by: yisaer <[email protected]>

fix lint

Signed-off-by: yisaer <[email protected]>

fix lint

Signed-off-by: yisaer <[email protected]>

fix lint

Signed-off-by: yisaer <[email protected]>

revise handle error

Signed-off-by: yisaer <[email protected]>

revise handle error

Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-6.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 22, 2022

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6dea31d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@ti-chi-bot ti-chi-bot merged commit a43bfe4 into pingcap:master Mar 22, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 22, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IT mysql_test index_merge_sqlgen_exprs failed
6 participants