Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr: switch off left push down due to intergration test failed (#33302) #33304

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 22, 2022

cherry-pick #33302 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33304

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33304:release-6.0-a43bfe4d7e31

What problem does this PR solve?

Issue Number: close #33255 #33256

Problem Summary:

What is changed and how it works?

switch off left push down due to intergration test failed which block 6.0 release. After we find out bug, we will switch on left push down again

I run mysql-test with this request, the result is expected.

$ ./mysql_test -host 127.0.0.1 -port 4000 -user root -params '&allowNativePasswords=true&allowAllFiles=true' index_merge_sqlgen_exprs_orandor_1_no_out_trans
INFO[0000] running tests: [index_merge_sqlgen_exprs_orandor_1_no_out_trans] 
WARN[0000] Create new db&{0 0xc0000b2000 0 {0 0} [0xc0000be000] map[] 0 1 0xc0000b4000 false map[0xc0000be000:map[0xc0000be000:true]] map[] 0 0 0 0 <nil> 0 0 0 0 0x1088dc0} 
./t/index_merge_sqlgen_exprs_orandor_1_no_out_trans.test: ok! 10173 test cases passed, take time 23.954630325 s
INFO[0024] run test [index_merge_sqlgen_exprs_orandor_1_no_out_trans] ok 
$ ./mysql_test -host 127.0.0.1 -port 4000 -user root -params '&allowNativePasswords=true&allowAllFiles=true' index_merge_sqlgen_exprs
INFO[0000] running tests: [index_merge_sqlgen_exprs]    
WARN[0000] Create new db&{0 0xc000010090 0 {0 0} [0xc00013a6c0] map[] 0 1 0xc000102180 false map[0xc00013a6c0:map[0xc00013a6c0:true]] map[] 0 0 0 0 <nil> 0 0 0 0 0x1088dc0} 
./t/index_merge_sqlgen_exprs.test: ok! 533 test cases passed, take time 2.163011253 s
INFO[0002] run test [index_merge_sqlgen_exprs] ok  

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.0-cherry-pick labels Mar 22, 2022
@ti-srebot
Copy link
Contributor Author

@Yisaer you're already a collaborator in bot's repo.

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: de7bc01

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2022
@VelocityLight
Copy link

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 24, 2022

@hawkingrei
Copy link
Member

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Yisaer
Copy link
Contributor

Yisaer commented Mar 24, 2022

/run-mysql-test

2 similar comments
@Yisaer
Copy link
Contributor

Yisaer commented Mar 24, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor

Yisaer commented Mar 24, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor

Yisaer commented Mar 24, 2022

/run-all-tests

@Yisaer
Copy link
Contributor

Yisaer commented Mar 24, 2022

/run-mysql-test

2 similar comments
@Yisaer
Copy link
Contributor

Yisaer commented Mar 24, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor

Yisaer commented Mar 24, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 9277dc9 into pingcap:release-6.0 Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants