Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: be compatible with deprecated stmt-summary config items #33448

Closed
wants to merge 6 commits into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 25, 2022

What problem does this PR solve?

Issue Number: close #33337

Problem Summary: config: be compatible with deprecated stmt-summary config items

What is changed and how it works?

config: be compatible with deprecated stmt-summary config items

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Mar 25, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-6.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2022
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should remove it in one version. It must throw out an error in the near future?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 25, 2022

LGTM, but we should remove it in one version. It must throw out an error in the near future?

Seem like it, that should be decided by our PM. For release-6.0, we'd better keep it now.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2022
@djshow832
Copy link
Contributor

/merge

@qw4990 qw4990 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 25, 2022

This approach to fix #33337 is not correct, I'll submit another PR later.

@qw4990 qw4990 closed this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to v6.0.0 fail when old cluster include stmt-summary config
4 participants