Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to v6.0.0 fail when old cluster include stmt-summary config #33337

Closed
seiya-annie opened this issue Mar 23, 2022 · 1 comment · Fixed by #33449
Closed

upgrade to v6.0.0 fail when old cluster include stmt-summary config #33337

seiya-annie opened this issue Mar 23, 2022 · 1 comment · Fixed by #33449
Assignees
Labels
affects-6.0 severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@seiya-annie
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. install v5.4.0 with config:
    stmt-summary.enable
    stmt-summary.enable-internal-query
    stmt-summary.history-size
    stmt-summary.max-sql-length
    stmt-summary.max-stmt-count
    stmt-summary.refresh-interval
  2. upgrade to 6.0.0

2. What did you expect to see? (Required)

stmt-summary config can be ignored during upgrade

3. What did you see instead (Required)

upgrade fail
Error: init config failed: 172.16.5.101:4000: executor.ssh.execute_failed: Failed to execute command over SSH for '[email protected]:22' {ssh_stderr: , ssh_stdout: [2022/03/23 12:48:15.840 +08:00] [FATAL] [terror.go:292] ["unexpected error"] [error="config file /home/tidb/deploy/tidb-4000/conf/tidb.toml contained invalid configuration options: enable-streaming, stmt-summary, stmt-summary.enable, stmt-summary.enable-internal-query, stmt-summary.history-size, stmt-summary.max-sql-length, stmt-summary.max-stmt-count, stmt-summary.refresh-interval; check TiDB manual to make sure this option has not been deprecated and removed from your TiDB version if the option does not appear to be a typo"]

4. What is your TiDB version? (Required)

v6.0.0 2022-03-22T19:47:19+08:00

@seiya-annie seiya-annie added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra labels Mar 23, 2022
@seiya-annie
Copy link
Author

@morgo hi, why these stmt-summary configs are not ignored during upgrade

@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 labels Mar 23, 2022
@jebter jebter added affects-6.0 and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.0 severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
4 participants