Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: be compatible with deprecated stmt-summary config items (#33449) #33450

Merged
merged 5 commits into from
Mar 28, 2022
Merged

config: be compatible with deprecated stmt-summary config items (#33449) #33450

merged 5 commits into from
Mar 28, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 25, 2022 •
edited
Loading

cherry-pick #33449 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33450

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33450:release-6.0-17408b432336

What problem does this PR solve?

Issue Number: close #33337

Problem Summary: config: be compatible with deprecated stmt-summary config items

What is changed and how it works?

config: be compatible with deprecated stmt-summary config items

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 25, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.0-cherry-pick type/bugfix This PR fixes a bug. labels Mar 25, 2022
@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 28, 2022
@qw4990
Copy link
Contributor

qw4990 commented Mar 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 870145d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b5549e7d14db3b45acfc2efdd005296b6fb72c88

@qw4990
Copy link
Contributor

qw4990 commented Mar 28, 2022

/run-mysql-test

@qw4990
Copy link
Contributor

qw4990 commented Mar 28, 2022

/run-all-tests

@hawkingrei
Copy link
Member

/run-mysql-test
/run-unit-test

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Mar 28, 2022

/run-mysql-test
/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e95812d into pingcap:release-6.0 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@djshow832 djshow832 djshow832 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees

@qw4990 qw4990

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ti-srebot @ti-chi-bot @qw4990 @sre-bot @hawkingrei @morgo @wjhuang2016 @djshow832 @VelocityLight