Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix KVRange bug for index join with dynamic partition pruning #33483

Merged
merged 2 commits into from
Mar 30, 2022
Merged

executor: fix KVRange bug for index join with dynamic partition pruning #33483

merged 2 commits into from
Mar 30, 2022

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Mar 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #33231

Problem Summary:

What is changed and how it works?

Please see the comments in the code and #33231 (comment).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • None

Documentation

  • NA

Release note

Fix the issue that query result might be wrong when using dynamic partition pruning mode with index join.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2022
@bb7133 bb7133 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8118bcd634170fffe3dd600b73f0a20d0d63e205

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 28, 2022
@bb7133 bb7133 requested review from XuHuaiyu, mjonss and tiancaiamao and removed request for XuHuaiyu March 28, 2022 08:25
@bb7133
Copy link
Member Author

bb7133 commented Mar 28, 2022

PTAL @XuHuaiyu @mjonss @tiancaiamao

mjonss
mjonss approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2022
@bb7133
Copy link
Member Author

bb7133 commented Mar 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e7a86e0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2022
@ti-chi-bot ti-chi-bot merged commit e560137 into pingcap:master Mar 30, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@bb7133 @ti-srebot
cherry pick pingcap#33483 to release-5.1
193dd53 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33579

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@bb7133 @ti-srebot
cherry pick pingcap#33483 to release-5.2
e909cf3 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33580

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@bb7133 @ti-srebot
cherry pick pingcap#33483 to release-5.3
8ef9061 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33581

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@bb7133 @ti-srebot
cherry pick pingcap#33483 to release-5.4
d73d922 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33582

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@bb7133 @ti-srebot
cherry pick pingcap#33483 to release-6.0
f864f92 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33583

@bb7133 bb7133 deleted the bb7133/bb7133_33231 branch December 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@mjonss mjonss mjonss approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set tidb_partition_prune_mode dynamic,IndexJoin return incorrect record
6 participants
@bb7133 @ti-chi-bot @sre-bot @ti-srebot @tiancaiamao @mjonss