-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix execute failed when table schema changed #33519
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the bench bot to verify if there's regression risk.
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b55685523b2753a87047539d520bbe1b256d1e62 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we have a schema version together with the ColumnInfo so we can still reuse the objects and at the same time avoid the bug?
I did not found it. Theoretically yes, we can add it but it will be more complicated and may cause some potential bugs |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b556855
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #33572 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #33573 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #33574 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #33575 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.3 in PR #33576 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.4 in PR #33577 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.0 in PR #33578 |
…ap#33519) (pingcap#33577)" This reverts commit 4001a16.
What problem does this PR solve?
Issue Number: close #33509
Problem Summary:
What is changed and how it works?
revert some changes in #12388 that will cause some panic
Check List
Tests
Side effects
resultSet's columns cache is disabled for different query that will cause a tiny performance down.
Documentation
Release note