-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix execute failed when table schema changed (#33519) #33577
executor: fix execute failed when table schema changed (#33519) #33577
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7e31b676e6888d004d4e3e8e231f24a29a4a4391 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a9737c7
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…ap#33519) (pingcap#33577)" This reverts commit 4001a16.
cherry-pick #33519 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33577
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #33509
Problem Summary:
What is changed and how it works?
revert some changes in #12388 that will cause some panic
Check List
Tests
Side effects
resultSet's columns cache is disabled for different query that will cause a tiny performance down.
Documentation
Release note