lightning: fix test lightning_error_summary

[sleepymole]

What problem does this PR solve?

Issue Number: close #33614

Problem Summary:

#33510 skipped recording retryalbe error to checkpoint so that lightning can resume automatically. However, utils.IsRetryableError returns true for all unknown error. And not all unknown error is recoverable, such as checksum mismatch. We can check for checksum mismatch error specifically, but it is a little ugly.

tidb/br/pkg/utils/retry.go

Lines 132 to 136 in e15e6d0

	case codes.Unknown:
	if reflect.TypeOf(err) == stdErrorType {
	return !stdFatalErrorsRegexp.MatchString(err.Error())
	}
	return true

What is changed and how it works?

Remove the condition utils.IsRetryableError for recoverable errors.

Perhaps we should add a new function like IsRecoverableError that treats all unknown error as unrecoverable. It may be improved in the later. This PR is just to fix the integration test.

Check List

Tests

• Unit test
• Integration test

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• D3Hunter
• lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/621b7401f197dbf37075852b102d99eceeddd6c2

[sleepymole]

/run-integration-br-test

[ti-chi-bot]

@buchuitoudegou: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[lichunzhu]

LGTM

[sleepymole]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: f21bd06

[ti-chi-bot]

@gozssky: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.