planner: fix order by sub-query couldn't find outer correlated columns

[AilinKid]

Signed-off-by: AilinKid [email protected]

What problem does this PR solve?

Issue Number: close #26945

Problem Summary:

DROP TABLE IF EXISTS t1, t2;
CREATE TABLE t1 (a INT, b INT);
CREATE TABLE t2 (a INT, b INT);
INSERT INTO t1 VALUES (1, 1);
INSERT INTO t2 VALUES (1, 1);
SELECT one.a FROM t1 one ORDER BY (SELECT two.b FROM t2 two WHERE two.a = one.b);

What is changed and how it works?

fetch the correlated column in order-by subquery out to select fields, building it as an Auxiliary one, which will be stored as p.schema() (passing as outer schema when enter subquery) when we try to build order-by clause. Otherwise it couldn't find that correlated column.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

planner: fix order by sub-query couldn't find outer correlated columns

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• winoros
• xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[AilinKid]

/run-unit-test

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8272b2fb0ec8cb413ae9cc3ccbc44cabcc5d7d0b

[time-and-fate]

If this subquery is or contains a non-correlated scalar subquery, it will be executed in it. Then it would cause the subquery to be executed twice, which may result in a regression.
I think we can add a special option into the rewrite to make it not execute the subquery in this case.

[AilinKid]

make sense，we will reduce it in later version. it's just a temporary solution

[AilinKid]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 97e8065

[AilinKid]

/run-unit-test

[ti-srebot]

cherry pick to release-5.0 in PR #33685

[ti-srebot]

cherry pick to release-5.1 in PR #33686

[ti-srebot]

cherry pick to release-5.2 in PR #33687

[ti-srebot]

cherry pick to release-5.3 in PR #33688

[ti-srebot]

cherry pick to release-5.4 in PR #33689

[ti-srebot]

cherry pick to release-6.0 in PR #33690