-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix unstable s3 test (#33610) #33647
base: release-5.4
Are you sure you want to change the base?
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@YuJuncen you're already a collaborator in bot's repo. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f855974fde96b8fbdda367da47fd99be63125511 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-5.4 #33647 +/- ##
================================================
Coverage ? 63.8116%
================================================
Files ? 775
Lines ? 255574
Branches ? 0
================================================
Hits ? 163086
Misses ? 79560
Partials ? 12928 |
cherry-pick #33610 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33647
After apply modifications, you can push your change to this PR via:
Signed-off-by: Yu Juncen [email protected]
What problem does this PR solve?
Issue Number: close #33644
Problem Summary:
The test case
br_s3
is unstable. The reason would probably be thatcurl
exit with0
even it met a 503 HTTP CODE. At this condition,mc
would fail soon and so did the test.What is changed and how it works?
Test the status code instead of the exit code of curl.
Check List
Tests
Release note