Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix unstable s3 test (#33610) #33647

Open
wants to merge 1 commit into
base: release-5.4
Choose a base branch
from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 1, 2022

cherry-pick #33610 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33647

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33647:release-5.4-d3245357d08d

Signed-off-by: Yu Juncen [email protected]

What problem does this PR solve?

Issue Number: close #33644

Problem Summary:

The test case br_s3 is unstable. The reason would probably be that curl exit with 0 even it met a 503 HTTP CODE. At this condition, mc would fail soon and so did the test.

What is changed and how it works?

Test the status code instead of the exit code of curl.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 1, 2022
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.4-cherry-pick labels Apr 1, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 1, 2022
4 tasks
@ti-srebot
Copy link
Contributor Author

@YuJuncen you're already a collaborator in bot's repo.

@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2022

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Jun 23, 2022
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-5.4@b1c5a67). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-5.4     #33647   +/-   ##
================================================
  Coverage               ?   63.8116%           
================================================
  Files                  ?        775           
  Lines                  ?     255574           
  Branches               ?          0           
================================================
  Hits                   ?     163086           
  Misses                 ?      79560           
  Partials               ?      12928           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants