Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix unstable s3 test #33610

Merged
merged 8 commits into from
Apr 1, 2022
Merged

br: fix unstable s3 test #33610

merged 8 commits into from
Apr 1, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 31, 2022 •
edited
Loading

Signed-off-by: Yu Juncen [email protected]

What problem does this PR solve?

Issue Number: close #33644

Problem Summary:

The test case br_s3 is unstable. The reason would probably be that curl exit with 0 even it met a 503 HTTP CODE. At this condition, mc would fail soon and so did the test.

What is changed and how it works?

Test the status code instead of the exit code of curl.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@YuJuncen
fix s3 test
efe7393 
Signed-off-by: Yu Juncen <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2022
@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@YuJuncen
try fix again
26dcfbb 
Signed-off-by: Yu Juncen <[email protected]>
@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

1 similar comment
@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/74944ec674aab5831fa0b2912435524f968063a9

@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@YuJuncen
make range better
8078b75 
Signed-off-by: Yu Juncen <[email protected]>
@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

4 similar comments
@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@YuJuncen
Copy link
Contributor Author

/run-integration-br-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2022
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 1, 2022

/run-integration-br-tests

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 and removed do-not-merge/needs-linked-issue labels Apr 1, 2022
@3pointer
Copy link
Contributor

3pointer commented Apr 1, 2022

/run-integration-br-tests

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 1, 2022

br_s3 started successfully.🤔

joccau
joccau approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2022
@3pointer
Copy link
Contributor

3pointer commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4c5dfc9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@3pointer
Copy link
Contributor

3pointer commented Apr 1, 2022

/run-check-dev_2

@ti-chi-bot ti-chi-bot merged commit d324535 into pingcap:master Apr 1, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 1, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33610 to release-5.3
9a6436a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 1, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33646

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 1, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33610 to release-5.4
f855974 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 1, 2022
Open
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33647

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 1, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33610 to release-6.0
ae42996 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 1, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33648

@YuJuncen YuJuncen mentioned this pull request Apr 2, 2022
Merged
4 tasks
This was referenced Apr 2, 2022
Closed
Open
Closed
@YuJuncen
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 13, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33610 to release-5.2
b89d7e8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: unstable test br_s3
6 participants
@YuJuncen @ti-chi-bot @sre-bot @3pointer @ti-srebot @joccau