Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: Fix unstable s3 test (again) #33666

Merged
merged 13 commits into from
Apr 2, 2022
Merged

br: Fix unstable s3 test (again) #33666

merged 13 commits into from
Apr 2, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Apr 2, 2022

Signed-off-by: Yu Juncen [email protected]

What problem does this PR solve?

Issue Number: close #33644

Problem Summary:

#33610 ignored a priority of operator. Which doesn't really fixed the problem.

What is changed and how it works?

Added a bracket to the conditions. (Bash is awesome!)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2022
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 2, 2022

/run-integration-br-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e0248c9e0a8066d448b0602ffb0ecae52f06584d

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2022
@YuJuncen YuJuncen requested a review from 3pointer April 2, 2022 05:07
@3pointer
Copy link
Contributor

3pointer commented Apr 2, 2022

/run-check-dev_2

1 similar comment
@3pointer
Copy link
Contributor

3pointer commented Apr 2, 2022

/run-check-dev_2

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 2, 2022

/integration-br-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2022
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 2, 2022

/run-check-dev_2

@3pointer
Copy link
Contributor

3pointer commented Apr 2, 2022

/run-check-dev

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 2, 2022

/run-check_dev_2

@ngaut
Copy link
Member

ngaut commented Apr 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e02a8a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2022
@joccau
Copy link
Member

joccau commented Apr 2, 2022

/run-integration-br-test

@ti-chi-bot ti-chi-bot merged commit b857293 into pingcap:master Apr 2, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33666 to release-5.3
bad1d03 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33682

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33666 to release-5.4
26155be 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Open
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33683

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33666 to release-6.0
f93a4d4 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut ngaut approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: unstable test br_s3
8 participants
@YuJuncen @ti-chi-bot @sre-bot @3pointer @ngaut @joccau @ti-srebot @hawkingrei