Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update client-go to fix data race #33775

Merged
merged 4 commits into from
Apr 8, 2022
Merged

*: update client-go to fix data race #33775

merged 4 commits into from
Apr 8, 2022

Conversation

youjiali1995
Copy link
Contributor

close #33773

Signed-off-by: youjiali1995 [email protected]

What problem does this PR solve?

Issue Number: close #33773

Problem Summary:

refer to tikv/client-go#464

What is changed and how it works?

update client-go

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that TiDB server may panic due to data race in client-go.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 and removed do-not-merge/needs-triage-completed labels Apr 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/996942ea3c54af8380c838ee9106954f9c0086ba

This was referenced Apr 7, 2022
Closed
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2022
@disksing
Copy link
Contributor

disksing commented Apr 8, 2022

LGTM. But I think release-5.x cannot cherry-pick automatically.

@youjiali1995
Copy link
Contributor Author

@disksing Yes, I have cherry-picked it manually.

@youjiali1995
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 51a542c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2022
@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 labels Apr 8, 2022
@ti-chi-bot ti-chi-bot merged commit 07b0e4d into pingcap:master Apr 8, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@youjiali1995 @ti-srebot
cherry pick pingcap#33775 to release-5.0
4a4786b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33823

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@youjiali1995 @ti-srebot
cherry pick pingcap#33775 to release-5.1
4005c49 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33824

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@youjiali1995 @ti-srebot
cherry pick pingcap#33775 to release-5.2
a260790 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33825

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@youjiali1995 @ti-srebot
cherry pick pingcap#33775 to release-5.3
276bd29 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33826

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@youjiali1995 @ti-srebot
cherry pick pingcap#33775 to release-5.4
9c6f6c0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33827

@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33828

youjiali1995 added a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@youjiali1995
cherry pick pingcap#33775 to release-6.0
8caa850 
Signed-off-by: ti-srebot <[email protected]>
Signed-off-by: youjiali1995 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@AndreMouche AndreMouche Awaiting requested review from AndreMouche

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic due to data race in connArray
6 participants
@youjiali1995 @ti-chi-bot @sre-bot @disksing @ti-srebot @Defined2014