types: fix bad error message for numeric conversion issue#32744

[fanrenhoo]

Signed-off-by: fanrenhoo [email protected]

What problem does this PR solve?

Issue Number: close #32744

Problem Summary: Tidb give incorrect warning message for string to decimal conversion, not compatible with MySQL

What is changed and how it works?

Change the warning message from "Bad Number" to "Truncated incorrect DECIMAL...."

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

DROP TABLE IF EXISTS t0;
CREATE TABLE t0 (c0 DECIMAL);
INSERT INTO t0 VALUES (1);
SELECT * FROM t0 WHERE t0.c0 > 'a';
SHOW WARNINGS

+---------+------+----------------------------------------+
| Level | Code | Message |
+---------+------+----------------------------------------+
| Warning | 1292 | Truncated incorrect DECIMAL value: 'a' |
+---------+------+----------------------------------------+
1 row in set (0.00 sec)

• No code

Side effects
No

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation
No

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Make tidb give correct warning message as MySQL does for string to decimal conversion cases, fix issue #32744

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• hawkingrei
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[fanrenhoo]

/cc @xhebox

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d4e7716c4fd050f1623b5a1b1689f23755b0c1e7

[fanrenhoo]

Hi, what's next for this one?

[fanrenhoo]

@hawkingrei Hi, how about this one? THKS

[hawkingrei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: a5b1446

[ti-chi-bot]

@fanrenhoo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.